[Some such feature is commonly requested.  Doing this at notify_do
time seems about right (in case of network disconnection, this might
be later than the "cvs edit".  But that is the best we can do under
the circumstances, unless I've failed to think of something).

The details of this patch of course, er, uh, need work.  But the idea
of just adding such a warning seems to be worth mentioning.

-kingdon]

Date: Wed, 5 Feb 97 16:08:26 PST
From: mpp@miteksys.com (Michal Prussak)
To: bug-cvs@prep.ai.mit.edu
Reply-To: mpp@miteksys.com


>Submitter-Id:   net
>Originator: 	 Michal Prussak
Michal Prussak
>Organization:
net
>Confidential:  no
>Synopsis:	Want to add optional warnings for cvs edit on files edited by others
>Severity:	non-critical
>Priority:	low
>Category: 	cvs
>Class:		change-request
>Release:	cvs-1.9
>Environment:
    	
System: SunOS mitekgold 4.1.3 2 sun4c
Architecture: sun4

>Description:
I would like the functionality that would optionally print a message
when a user cvs edits a file that is already edited by someone else.
This way (in combination with cvs watch) developers know who else edits
the same files as they do.
	
>How-To-Repeat:
	
>Fix:
	
I have temporarily added this code to edit.c, function notify_do,
starting at line 815:

#ifdef WARN_ON_CONCURRENT_EDIT
	if (strcmp(args.type, "temporary edit") == 0) {
		cvs_output("Warning: file ", 0);
		cvs_output(args.file, 0);
		cvs_output(" is edited by ", 0);
		cvs_output(args.notifyee, 0);
		cvs_output("\n", 1);
	} else if (strcmp(args.type, "edit") == 0) {
		cvs_output("Notice: file ", 0);
		cvs_output(args.file, 0);
		cvs_output(" is edit-watched (and may be edited) by ", 0);
		cvs_output(args.notifyee, 0);
		cvs_output("\n", 1);
	}
#endif

This fix is not perfect, because it relies on temporary watches rather than
really checking the editors information for each file, but it was easier
for me to implement and sufficient for my needs. If a real fix can't be
made (with checking of editors information) then I would ask that this fix
be included in future releases.