[Needs a test case. Needs to check for errors from unlink_file. I'm also not completely clear on whether ignoring blank lines is correct or whether it should be an error. I'd probably go for ignoring blank lines (like we do in CVSROOT/config) but I might want to think about it a bit more. -kingdon] To: bug-cvs@gnu.org Subject: scanning $CVSROOT/CVSROOT/checkoutlist From: KOIE Hidetaka X-PGP-Fingerprint: 34 F4 D5 48 D0 18 EE 24 5B 1A DD 23 BF 73 19 03 X-PGP-Public-Key-URL: http://www2s.biglobe.ne.jp/~koie-hed/public_key.txt Content-Type: Multipart/Mixed; boundary="--Next_Part(Wed_Aug__5_13:59:18_1998_595)--" Date: Wed, 5 Aug 1998 14:04:51 +0900 ----Next_Part(Wed_Aug__5_13:59:18_1998_595)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit A function mkmodules cannot handle empty lines. So, temporary files like `.#12345' remain in $CVSROOT/CVSROOT. -- KOIE Hidetaka koie@suri.co.jp SURIGIKEN CO.,LTD. ----Next_Part(Wed_Aug__5_13:59:18_1998_595)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=patch-mkmodules.c --- mkmodules.c.org Tue Feb 17 12:26:37 1998 +++ mkmodules.c Wed Aug 5 13:53:22 1998 @@ -450,6 +450,11 @@ /* Skip leading white space. */ for (fname = line; *fname && isspace(*fname); fname++) ; +#if 1 /* KOIE */ + /* skip empty lines. */ + if (fname == last) + continue; +#endif /* Find end of filename. */ for (cp = fname; *cp && !isspace(*cp); cp++) @@ -463,10 +468,18 @@ } else { +#if 1 /* KOIE */ + for (cp++; cp < last && isspace(*cp); cp++) + ; + if (cp < last) + error (0, 0, cp, fname); + (void) unlink_file (temp); +#else for (cp++; cp < last && *last && isspace(*last); cp++) ; if (cp < last && *cp) error (0, 0, cp, fname); +#endif } free (temp); } ----Next_Part(Wed_Aug__5_13:59:18_1998_595)----