[Based on a very quick look at the code, this would seem to be true. And perhaps has been true since the CVSROOT/users feature was first added. If fixing this, would be nice to include a testcase so it stays fixed. Or does the fact that few people have noticed the problem tell us something about whether CVSROOT/users is really needed or just a creeping feature? -kingdon] Date: Sat, 7 Feb 1998 02:19:08 -0500 From: Paul To: bug-cvs@prep.ai.mit.edu >Submitter-Id: net >Originator: Paul >Organization: net >Confidential: no >Synopsis: cvs notification broken using 'users' file >Severity: >Priority: >Category: cvs >Class: sw-bug >Release: cvs-1.9 >Environment: System: Linux squish 2.0.33 #3 Wed Jan 28 20:41:50 EST 1998 i486 Using remote repository. Architecture: i486 >Description: When using 'cvs watch on file; cvs watch add all file', and someone triggers notification via 'cvs edit file ; etc' the line in CVSROOT/notify looking like: ALL mail %s -s \"subect message\" combined with a CVSROOT/users file having something like: bob:bob@place.com sue:suebee@elseplace.com will result in an error, because a newline exists in the %s substitution. An example of 'cvs -t edit' follows: -> ParseInfo(/usr/local/cvsdir/CVSROOT/notify, perc/conf, ALL) S-> run_popen(mail sjlee@newmonics.com -s \"CVS notification: You heard it first!\",w) sh: -s: command not found S-> unlink_file_dir(/tmp/cvs-serv12174) -> chmod(Config,100666) -> copy(Config,CVS/Base/Config) -> Starting server: c:\bin\ssh newmonics.com cvs server Note the 'sh: -s: command not found' >How-To-Repeat: >Fix: